Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README up date: go get deprecated #58

Open
oswinfox opened this issue Oct 18, 2022 · 3 comments
Open

README up date: go get deprecated #58

oswinfox opened this issue Oct 18, 2022 · 3 comments

Comments

@oswinfox
Copy link

Hello guys,

In the README.md file it use go get command when it is deprecated. We have to use go install github.com/griesbacher/nagflux@latest instead.

see got get output:

go get -v -u github.com/griesbacher/nagflux
go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

Cheers

@oswinfox
Copy link
Author

When trying to use go install github.com/griesbacher/nagflux@latest command I have this error:

root/gorepo/pkg/mod/github.com/griesbacher/nagflux@v0.4.1/statistics/prometheus.go:109:39: undefined: prometheus.Handler

It seems we should change the prometheus.Handler to promhttp.Handler in the file nagflux/statistics/prometheus.go can someone check this issue?

@Captn138
Copy link

The change you suggest seems to be the right one, also we need to import "github.com/prometheus/client_golang/prometheus/promhttp" as weel.

@ebasse-prog
Copy link

ebasse-prog commented Mar 1, 2023

I have tis sam problem.
I added github.com/prometheus/client_golang/prometheus/promhttp line and display error:

# github.com/griesbacher/nagflux/statistics
./prometheus.go:8:1: could not import github.com/prometheus/client_golang/prometheus/promhttp (open : no such file or directory)

Before, change from:
prometheus.Handler to promhttp.Handler in the file nagflux/statistics/prometheus.go not help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants