Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Use Context instead of Props #32

Open
ryanlanciaux opened this issue Nov 22, 2015 · 1 comment
Open

[Discussion] Use Context instead of Props #32

ryanlanciaux opened this issue Nov 22, 2015 · 1 comment

Comments

@ryanlanciaux
Copy link
Member

Mostly for plugins : I think we should consider switching from props to context. Currently when we have plugins that are HoCs, they need to know about everything that should come after it. Maybe we should just pass ...props from the HoC components but another option would be using contexts. There are likely some other benefits from this as well. Any thoughts around this?

@yorchv
Copy link

yorchv commented Jun 7, 2016

I have to say that context is not an official feature, and should be handled with care and the possibility that it can be removed. On the other side, popular libraries, like redux, have high dependency on that feature as well.

One thing with the context is that is more appropriate to data handling than to have it saving the state of the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants