Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Customization section" link in "Getting started" docs doesn't work if accessed directly via nav #22

Open
robbieaverill opened this issue Jan 9, 2019 · 0 comments

Comments

@robbieaverill
Copy link
Contributor

robbieaverill commented Jan 9, 2019

Griddle version

http://griddlegriddle.github.io/Griddle/docs/

Expected Behavior

Clicking "customization section" should take you to http://griddlegriddle.github.io/Griddle/docs/customization/

Actual Behavior

It takes you to http://griddlegriddle.github.io/Griddle/customization

Steps to reproduce

Pull request with failing test or storybook story with issue

While this step is not necessary, a failing test(s) and/or a storybook story will help us resolve the issue much more easily. Please see the README for more information.


Note that if you load the page directly, or refresh the page after loading it via the navigation links, the link is now correct.

The links were both changes in #19, neither link works in this context. It looks like you'd need to use prefixLink() on them, but since it's markdown syntax I'm not sure how you'd implement that.

Presumably this only affects the index page, since it doesn't have a name in the URL. Links like this are where the issue is:

<a href="../customization">customization section</a>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant