Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting and Filter not working #821

Open
andychongyz opened this issue Jul 2, 2018 · 1 comment
Open

Sorting and Filter not working #821

andychongyz opened this issue Jul 2, 2018 · 1 comment

Comments

@andychongyz
Copy link

andychongyz commented Jul 2, 2018

At first, I thought it was because the react and react-dom version is ^16.0.0, but I set it to 15.3.2, which is used in the storybook, the problem still remained. And there is no error or warning given on the chrome console!

I pass in the custom events, and it fires too!
screen shot 2018-07-02 at 8 13 50 pm

Any help will be really appreciated! 🙏

Griddle version

1.13.1

Expected Behavior

When clicking the header, it doesn't sort the rows.
When typing anything into the filter, it returns an empty table.

Actual Behavior

Clicking on the header should sort the row based on the column clicked.
Typing into the filter should filter the table.

Steps to reproduce

Not super sure, but this is all the dependencies in my app:

    "@types/googlemaps": "^3.0.0",
    "@types/markerclustererplus": "^2.1.29",
    "@types/react": "^15.0.0",
    "actioncable": "^5.1.4",
    "autoprefixer": "^7.1.1",
    "babel": "^6.5.2",
    "babel-cli": "^6.6.5",
    "babel-core": "^6.7.4",
    "babel-loader": "^7.1.2",
    "babel-plugin-add-react-displayname": "^0.0.5",
    "babel-preset-es2015": "^6.6.0",
    "babel-preset-react": "^6.5.0",
    "babel-preset-stage-0": "^6.5.0",
    "babel-runtime": "^6.6.1",
    "bootstrap": "v4.0.0-alpha.6",
    "bootstrap-loader": "2.1.0",
    "bootstrap-validator": "^0.11.5",
    "braintree-web-drop-in": "^1.9.0",
    "clipboard": "^1.5.12",
    "compression-webpack-plugin": "^1.0.1",
    "css-loader": "^0.28.4",
    "disable-scroll": "^0.3.0",
    "es5-shim": "^4.5.7",
    "es6-promise": "^3.2.1",
    "exports-loader": "^0.6.4",
    "expose-loader": "^0.7.1",
    "extract-text-webpack-plugin": "^3.0.1",
    "file-loader": "^1.1.5",
    "griddle-react": "^1.11.2",
    "imports-loader": "^0.7.1",
    "intl-tel-input": "^12.1.0",
    "jquery": "^3.2.1",
    "jquery-ujs": "^1.2.2",
    "js-cookie": "^2.1.4",
    "js-yaml": "^3.8.4",
    "load-script": "^1.0.0",
    "loader-utils": "^0.2.13",
    "lodash": "^4.17.5",
    "logrocket": "^0.6.3",
    "logrocket-react": "^0.0.5",
    "lozad": "^1.0.9",
    "node-sass": "^4.9.0",
    "offline-plugin": "^4.8.4",
    "popper.js": "^1.12.3",
    "postcss": "^6.0.2",
    "postcss-flexbugs-fixes": "^3.0.0",
    "postcss-loader": "^2.0.6",
    "query-string": "^4.2.2",
    "react": "^15.3.2",
    "react-dom": "^15.3.2",
    "react-google-maps": "^9.2.2",
    "react-intersection-observer": "^2.0.3",
    "react-on-rails": "10.0.2",
    "recompose": "^0.25.1",
    "resolve-url-loader": "^2.0.3",
    "sass-loader": "^6.0.6",
    "sass-resources-loader": "^1.2.1",
    "selectize": "^0.12.1",
    "style-loader": "^0.18.2",
    "tether": "^1.3.2",
    "turbolinks": "^5.0.3",
    "url-loader": "^0.6.2",
    "url-search-params": "^0.9.0",
    "webpack": "^3.8.1",
    "webpack-manifest-plugin": "^1.3.2",
    "webpack-merge": "^4.1.0",
    "webpack-polyfill-injector": "^0.0.4"
  },
  "devDependencies": {
    "webpack-bundle-analyzer": "^2.8.2"
  }

Pull request with failing test or storybook story with issue

The storybook works fine.
While this step is not necessary, a failing test(s) and/or a storybook story will help us resolve the issue much more easily. Please see the README for more information.

@dahlbyk
Copy link
Contributor

dahlbyk commented Jul 5, 2018

So to clarify, you're finding the Storybook works as expected, but Griddle in your app is not working as expected? Can you share any of your code? Are you using LocalPlugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants