Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More than 8 columns display in an unexpected order #804

Open
erinknight242 opened this issue Apr 3, 2018 · 4 comments
Open

More than 8 columns display in an unexpected order #804

erinknight242 opened this issue Apr 3, 2018 · 4 comments

Comments

@erinknight242
Copy link

Griddle version

v.1.11.2

Expected Behavior

Columns will display in the order listed in the data (like it does for <=8 columns)

Actual Behavior

Columns appear in an unexpected order (7, 8, 9, 1, 2, 3, 4, 5, 6)

Steps to reproduce

Follow the Getting Started example, but with data with >8 columns:

<Griddle
  data={[
    { col1: '1', col2: '2', col3: '3', col4: '4', col5: '5',
      col6: '6', col7: '7', col8: '8', col9: '9'}
  ]}
  plugins={[plugins.LocalPlugin]}
/>
dahlbyk added a commit to dahlbyk/Griddle that referenced this issue Apr 3, 2018
@dahlbyk
Copy link
Contributor

dahlbyk commented Apr 3, 2018

Interesting. I would expect this to have been fixed by 3a74252 in #658.

Can you please try the new story added in #805? I'm not able to reproduce this.
image

@erinknight242
Copy link
Author

Agree; interesting. The storybook columns look correct for me as well; not sure why v1.11.2 installed in my app isn't working properly. I'll try to repro elsewhere.

@erinknight242
Copy link
Author

erinknight242 commented Apr 4, 2018

Ok; I was able to repro it. It seems to be related to my (rather undesirable) column names, which are formatted like a mm-dd date.

data={[
  { '00-00': '0', '01-01': '1', '02-02': '2', '03-03': '3', '04-04': '4',
    '05-05': '5', '06-06': '6', '07-07': '7', '08-08': '8', '09-09': '9', '10-10': '10' }
]}

screen shot 2018-04-04 at 7 54 29 am

@dahlbyk
Copy link
Contributor

dahlbyk commented Apr 4, 2018

Confirmed. No idea why. I just pushed a failing test to #805, if you care to look into what the problem may be in dataSelectors.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants