Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css #32

Open
ghost opened this issue Feb 8, 2016 · 9 comments
Open

Css #32

ghost opened this issue Feb 8, 2016 · 9 comments

Comments

@ghost
Copy link

ghost commented Feb 8, 2016

Hi!
Can you please explain how css per component works. Right now it seems like i have to introduce a new file for every component and include it with a link tag on my index.html and then refresh the page for changes to take place. Is this the right process? Am I doing something wrong?
Thanks

@kaiomagalhaes
Copy link

@Andreasi I've been doing the same, I think that it is the right way as we are not using any kind of assets injector.

@Granze
Copy link
Owner

Granze commented Feb 15, 2016

@Andreasi @kaiomagalhaes I'm thinking about improving all the CSS part of the starter kit. I'll take a look in the next days.

@kaiomagalhaes
Copy link

@Granze I`m just waiting an answer about the dockerfile merge to add a scss and a js+react lint

@Granze
Copy link
Owner

Granze commented Feb 15, 2016

@kaiomagalhaes I know and I'm sorry for the delay. I just came back from San Francisco. In the next days, I'll sort this out as well.

@ghost
Copy link
Author

ghost commented Feb 16, 2016

Thanks a lot you guys! Love the kit!!!

@Granze
Copy link
Owner

Granze commented Mar 9, 2016

So it seems I'll have some time in the next days to look at how to improve the CSS part of the starter kit.
Of course, the main goal is to stay minimal and as less opinionated as possible.

@kaiomagalhaes
Copy link

@Granze A really good thing to add would be some lints for scss and js

@Granze
Copy link
Owner

Granze commented Mar 9, 2016

There is a JS linter already in place.

On Wed, Mar 9, 2016, 17:33 Kaio Cristian Costa Porto de Magalhães <
notifications@github.com> wrote:

@Granze https://github.com/Granze A really good thing to add would be
some lints for scss and js


Reply to this email directly or view it on GitHub
#32 (comment)
.

@TimKraemer
Copy link

I'd really appreciate if this awesome kit also could handle modularized css. Unfortunately I'm not able to understand and modify the watchify/gulp workflow in a way to achieve this yet.

It would be great if we could have something like import btn from './button.css' inside an example button component, having the button.css lying in the same subdir like the button component itself.
(example: https://css-tricks.com/css-modules-part-3-react/#article-header-id-3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants