Stop adding PYTHON_CFGDIR to LD_RUN_PATH and PYTHON_LDFLAGS if there is no libpython #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is no libpython The PYTHON_CFGDIR variable is more or less something like /usr/lib64/python3.12/config. Not only does this directory not exist on Python 3.6+ (it is called differently), but there is no libpython.so in it. Adding it to LD paths makes no difference. I could fix up the way the path is determined, but I decided not to touch this code not to break old use cases. Instead, the directory is only added to LD paths when there is something relevant in it. Fixes GrahamDumpleton#872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PYTHON_CFGDIR variable is more or less something like /usr/lib64/python3.12/config.
Not only does this directory not exist on Python 3.6+ (it is called differently), but there is no libpython.so in it.
Adding it to LD paths makes no difference.
I could fix up the way the path is determined,
but I decided not to touch this code not to break old use cases.
Instead, the directory is only added to LD paths when there is something relevant in it.
Fixes #872