Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rel="0" in element docs #26

Open
ebidel opened this issue Jan 17, 2015 · 1 comment
Open

rel="0" in element docs #26

ebidel opened this issue Jan 17, 2015 · 1 comment

Comments

@ebidel
Copy link
Contributor

ebidel commented Jan 17, 2015

The example uses rel="0" but I can't find this param in the element. Is it leftover?

 <google-youtube
      videoid="..."
      height="270px"
      width="480px"
      rel="0"
      start="5"
      autoplay="1">
    </google-youtube>```
@jeffposnick
Copy link
Contributor

There is an amorphous set of supported player parameters for the standard YouTube embed, including rel: https://developers.google.com/youtube/player_parameters#rel

I took the approach of just passing through attributes set on <google-youtube> to the underlying YouTube embed, to give developers flexibility in setting what they want. That means that I'm relying on folks to look at the YouTube embed docs page to figure out what they want to set (though not all parameters are documented there...), with the chromeless attribute serving as a shortcut for the most common combination of settings.

It makes sense to me, but I can see why it would be confusing to the average developer not steeped in YouTube API history. I'll keep this open as a reminder that it would be better to at least at <google-youtube> documentation for the most stable player parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants