New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated. #3577

Open

xhyabunny opened this issue Nov 27, 2023 · 1 comment

Assignees

Labels

samples

xhyabunny commented Nov 27, 2023

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blame/2c008f81febaacb568eebfcc0f158c9215f8139b/translate/translate.js#L20

require is outdated, you guys should change it to Import.

people working with new frameworks like react.js/vite can not use stuff like "require" on their code

product-auto-label bot added the samples label

Contributor

iennae commented Mar 7, 2024

@xhyabunny Thanks so much for filing this issue. We'll add it to our roadmap of areas to update samples.

pattishin self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment