Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texttospeech/quickstart.js change the file to use fs/promises #3504

Open
andriotisnikos1 opened this issue Sep 15, 2023 · 0 comments
Open

texttospeech/quickstart.js change the file to use fs/promises #3504

andriotisnikos1 opened this issue Sep 15, 2023 · 0 comments
Assignees
@ivanmkc
Labels
api: texttospeech Issues related to the Text-to-Speech API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: question Request for information or clarification. Not an issue.

Comments

@andriotisnikos1
Copy link

andriotisnikos1 commented Sep 15, 2023 •
edited

hello! ive noticed that texttospeech/quickstart.js uses fs.writeFile synchronously, and is then promisified with 'util.promisify'. why not just use 'fs/promises' and not just 'fs'? it does the same thing, and the code is more understandable. lmk your opinion google team!
@product-auto-label product-auto-label bot added api: texttospeech Issues related to the Text-to-Speech API. samples Issues that are directly related to samples. labels Sep 15, 2023
@davidcavazos davidcavazos added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Sep 19, 2023
@balajismaniam balajismaniam added the type: question Request for information or clarification. Not an issue. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanmkc ivanmkc

Labels
api: texttospeech Issues related to the Text-to-Speech API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ivanmkc @davidcavazos @balajismaniam @andriotisnikos1