Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: add workflow for functions/v2/imagemagick sample #3477

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

testing: add workflow for functions/v2/imagemagick sample #3477

wants to merge 17 commits into from

Conversation

grayside
Copy link
Collaborator

Description

Fixes #3149

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@grayside grayside requested review from a team as code owners August 24, 2023 22:42
@grayside grayside self-assigned this Aug 24, 2023
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Aug 24, 2023
@grayside
Copy link
Collaborator Author

In order for this to pass, we need two environment variables in the test runtime:

  • FUNCTIONS_BUCKET where the image to be scanned is loaded
  • BLURRED_BUCKET_NAME where the modified image is loaded by the function execution

In Kokoro configuration, this looks like the following:

nodejs-docs-samples/.kokoro/build.sh

Line 49 in c6e0a09

export FUNCTIONS_BUCKET=$GOOGLE_CLOUD_PROJECT

nodejs-docs-samples/.kokoro/build.sh

Line 70 in c6e0a09

export BLURRED_BUCKET_NAME=$GOOGLE_CLOUD_PROJECT-imagick

However, I don't see an example of where the GOOGLE_CLOUD_PROJECT variable can be sourced in the GHA implementation of test runner.

@pattishin could you provide guidance?

@grayside grayside assigned pattishin and unassigned grayside Dec 6, 2023
@grayside
Copy link
Collaborator Author

grayside commented Dec 6, 2023

Reassigning to @pattishin to clarify this is blocked on my end until we have preferred direction on configuring the system test behaviors.

@pattishin pattishin removed their assignment Apr 25, 2024
@iennae
Copy link
Contributor

iennae commented Apr 26, 2024

@grayside this feels like an area where we need to define the practice; we don't have a recommended practice and we should think through how we should do this (not just for this service) but this will then allow us to provide the guidance for other sample contributors.

@grayside grayside added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
actions:force-run api: workflows Issues related to the Workflows API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

functions/v2/imagemagick not running in CI
3 participants
@grayside @iennae @pattishin