Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner/r2dbc test(s) are failing #8978

Closed
minherz opened this issue Jan 19, 2024 · 0 comments · Fixed by #9318
Closed

spanner/r2dbc test(s) are failing #8978

minherz opened this issue Jan 19, 2024 · 0 comments · Fixed by #9318
Assignees
@ssvir
Labels
api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: process A process-related concern. May include testing, release, or the like.

Comments

@minherz
Copy link
Contributor

minherz commented Jan 19, 2024 •
edited

After the upgrade of the Google client library BOM from 26.27.0 to 26.29.0 and cloud-spanner-r2dbc library from 1.2.2 to 1.3.0 made in #8971 com.example.spanner.r2dbc.R2dbcSampleApplicationIT.testAllWebEndpoints test under spanner/r2dbc fail with both Java 11 and Java 17 runtimes. See Java 11 sponge log for details of the failed assertions.

All the failing tests are marked as Ignored until the issue is fixed.
@minherz minherz added type: process A process-related concern. May include testing, release, or the like. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. triage me I really want to be triaged. labels Jan 19, 2024
@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Jan 19, 2024
minherz pushed a commit that referenced this issue Jan 19, 2024
@renovate-bot
chore(deps): update java (#8971)
e18aabf 
fix the transcribed phrase in speech recognition tests.
setup otel and spanner tests as failing (see #8978 and #8979)
@skuruppu skuruppu assigned arpan14 and unassigned skuruppu Jan 23, 2024
@ssvir ssvir assigned ssvir and unassigned arpan14 May 3, 2024
@ssvir ssvir mentioned this issue May 9, 2024
Merged
11 tasks
minherz pushed a commit that referenced this issue May 15, 2024
@ssvir
spanner/r2dbc test(s) are failing #8978 (#9318)
6cb666a 
adds creation of instance and only then creation of database, added after block to close delete instance, db and close all connections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssvir ssvir

Labels
api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spanner/r2dbc test(s) are failing #8978 GoogleCloudPlatform/java-docs-samples
5 participants
@skuruppu @minherz @arpan14 @ssvir and others