Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner/r2dbc test(s) are failing #8978 #9318

Merged
merged 2 commits into from May 15, 2024
Merged

spanner/r2dbc test(s) are failing #8978 #9318

merged 2 commits into from May 15, 2024

Conversation

ssvir
Copy link
Collaborator

@ssvir ssvir commented May 9, 2024

Description

added creation of the instance and only then the creation of database, added after block to close delete an instance, db and close all connections
Fixes #8978

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@ssvir
added creation of instance and only then creation of database, added …
9f07f61 
…after block to close delete instance, db and close all connections
@ssvir ssvir requested a review from Sita04 May 9, 2024 07:17
@ssvir ssvir requested review from yoshi-approver and a team as code owners May 9, 2024 07:17
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels May 9, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@Sita04 Sita04 assigned minherz and unassigned Sita04 May 15, 2024
minherz
minherz approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minherz minherz merged commit 6cb666a into main May 15, 2024
11 checks passed
@minherz minherz deleted the fix-issue-8978 branch May 15, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minherz minherz minherz approved these changes

@Sita04 Sita04 Awaiting requested review from Sita04

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@minherz minherz

Labels
api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner/r2dbc test(s) are failing
4 participants
@ssvir @minherz @Sita04 @kokoro-team