Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle methods not updated for "getting-started-grpc" #8976

Open
borah-hemanga opened this issue Jan 15, 2024 · 2 comments
Open

Gradle methods not updated for "getting-started-grpc" #8976

borah-hemanga opened this issue Jan 15, 2024 · 2 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@borah-hemanga
Copy link

In which file did you encounter the issue?

https://github.com/GoogleCloudPlatform/java-docs-samples/tree/main/endpoints/getting-started-grpc
While running: ./gradlew build

Did you change the file? If so, how?

Did not change the file.

Describe the issue

I tried setting up the package to try out running the grpc example locally. The first command fails.
The reason is that the gradle methods are not updated to the newer version.

(Tried to fix it myself, but everyone trying this out will run into this, and it is a waste of time for everyone fixing the methods.)

Thanks!

@borah-hemanga borah-hemanga added priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 15, 2024
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 15, 2024
@minherz
Copy link
Contributor

minherz commented Jan 17, 2024

Hello @borah-hemanga, thank you for reporting the issue. Are you referencing the version of the gradle CLI?
I checked the sample you reference and it uses gradle version 8.5 which is the latest version of the gradle.
Would you mind to share what you did to update the gradle methods to the newer version? You can also submit the change to gradlew script instead (following our contribution guide).

@minherz minherz added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. labels Jan 17, 2024
@borah-hemanga
Copy link
Author

borah-hemanga commented Jan 23, 2024

I started making changes, like changing compile to implementation. But, looks like there are other changes necessary, like configurations.compile.collect isn't present in the newer version either.

Anyway, I gave up on gRPC and just used HTTP instead.

But, it would be nice for other users if the gRPC sample worked out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants
@borah-hemanga @minherz @kweinmeister and others