Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakey m2e-related tests on Photon #3258

Open
briandealwis opened this issue Sep 27, 2018 · 1 comment
Open

Fix flakey m2e-related tests on Photon #3258

briandealwis opened this issue Sep 27, 2018 · 1 comment
Labels
build priority: p4 testing

Comments

@briandealwis
Copy link
Member

briandealwis commented Sep 27, 2018 •
edited

In trying to fix #3256 we found that com.google.cloud.tools.eclipse.integration.appengine.FlexMavenPackagedProjectStagingDelegateTest and com.google.cloud.tools.eclipse.integration.appengine.ImportMavenAppEngineStandardProjectTest were flaking on Photon, for reasons that we have not been able to figure out. These tests work fine locally.
@chanseokoh
Copy link
Contributor

Is it possible to disable them only on Photon with Assume.assumeFalse()? We don't want to spend too much time on it though.

briandealwis pushed a commit that referenced this issue Sep 27, 2018
@chanseokoh @briandealwis
Update target platform definitions (#3256)
9d0dc9d 
* ignore flakey integration tests (see #3258)
* reduce maven-compiler-plugin verboseness
* back out to Tycho 1.1.0 for meaningful stacktraces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build priority: p4 testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@briandealwis @chanseokoh @meltsufin