Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests aren't compatible with rennovatebot #162

Open
josephlewis42 opened this issue Sep 25, 2023 · 1 comment
Open

Integration tests aren't compatible with rennovatebot #162

josephlewis42 opened this issue Sep 25, 2023 · 1 comment
Labels
bug Something isn't working P2

Comments

@josephlewis42
Copy link
Contributor

Rennovatebot isn't creating branches on the local repository, so the conformance tests which require this are failing. It's likely they will also fail for other external PRs as well.

"google/cloud-functions-framework": "dev-'${GITHUB_HEAD_REF}'#'${FRAMEWORK_VERSION}'",

We should instead direct the integration tests to point at the currently checked out source in the GitHub action's pipeline. Perhaps something like this: https://stackoverflow.com/questions/29994088/composer-require-local-package

@josephlewis42 josephlewis42 added bug Something isn't working P3 labels Sep 25, 2023
@josephlewis42 josephlewis42 self-assigned this Sep 25, 2023
@josephlewis42 josephlewis42 added P2 and removed P3 labels Sep 25, 2023
@josephlewis42
Copy link
Contributor Author

Pinging @kenneth-rosario for GitHub Action knowledge, I think composer can use local files, but we might also be able to reference the remote repository in the prerun. Not sure which is best with pack involved.

@kenneth-rosario kenneth-rosario removed their assignment Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2
Projects
None yet
Development

No branches or pull requests

2 participants