Replace the need for the customizer when using a FSE theme

[carstingaxion]

Hello everyone here,
hello @westonruter,

when using a full-site-editing theme together with the pwa plugin, the only need for having the customizer visible is the setting to set the site_icon_maskable option.

I thought about creating a higher-order-component for the core/site-logo block to fill this gap.

What do you think?

[westonruter]

Hey, I'm not very familiar with it, but that sounds good.

[carstingaxion]

Hello again,

I'm sorry that my initial statement was maybe not that clear.

I was looking for a native way to handle the site_icon_maskable setting within a full-site-editing context, more clearly - adding this setting to the <InspectorControls> panel of the existing core/site-logo-block. Currently we have this UI only available inside the customizer, which is not that futureproof. Take a look at my first try.

I would like to contribute this to the plugin, if you're interested and we are able to solve some last issues.

[carstingaxion]

To bring theese changes to life, I think the following needs to be looked at:

• Where to put the source files, currently in ./site-icon-maskable?
• Integrate with npm run build and find a place for the (files of the) build directory?
• Use _pwa_print_build_needed_notice instead of the current throw new Error.
• Add more inline-documentation
• Add tests

For later

• Replace Flex & FlexItem with a non-experimental version of __experimentalHStack as soon as soemthing is available
• Replace __unstableBase with something non-experimental as soon as soemthing is available