Conflict with WordPress Updates screen

[swissspidy]

I had a few available plugin updates on my site and went to Dashboard -> Updates to install them.

When you run the updater, WordPress displays the progress in an iframe. But when the PWA plugin is installed, I only see the offline template instead of the progress. That is very odd.

[westonruter]

Interesting. Apparently that iframed URL is not in the admin? Apparently the service worker's navigation routing needs to exempt that URL from handling.

[swissspidy]

It looks like wp-admin/update-core.php iframes wp-admin/update.php, so it actually should be in the admin.

And it doesn't seem to happen every time I install updates, but I definitely recall this happening multiple times now.

[westonruter]

Ok, actually the admin also serves an offline template when it detects the user is offline. The iframe probably had the offline template and the message said that the server was offline, not the client, right? That offline detection is will have to be improved.

[swissspidy]

I don't recall the wording exactly, but that would explain it I think!

[westonruter]

Could it be that the error failed with an internal server error? If the service worker doesn't see </html> in the response, then it serves the offline template:

pwa-wp/wp-includes/js/service-worker-navigation-routing.js

Lines 45 to 47 in f6800eb

	if ( -1 !== responseBody.indexOf( '</html>' ) ) {
	return originalResponse;
	}

Can you replicate the issue by causing an error during update?