Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor.js:19 Uncaught (in promise) SyntaxError: The requested module '/@npm/@codemirror/commands' does not provide an export named 'defaultTabBinding' #5

Open
ethan666 opened this issue Aug 30, 2021 · 6 comments

Comments

@ethan666
Copy link

ethan666 commented Aug 30, 2021

@codemirror/commands CHANGELOG.md

0.19.0 (2021-08-11)
Breaking changes
Change default binding for backspace to deleteCharBackward, drop deleteCodePointBackward/Forward from the library.

defaultTabBinding was removed.

nomuna added a commit to nomuna/pwa-workshop-codelab that referenced this issue Sep 8, 2021
- replaced defaultTabBinding with indentWithTab

Fix GoogleChromeLabs#5
@joshtrotter
Copy link

Thanks for the fix @nomuna

@nomuna
Copy link

nomuna commented Sep 10, 2021

Thanks for the fix @nomuna

You are welcome. :D

@baspep
Copy link

baspep commented Oct 15, 2021

just a FYI - the fix has not made it to the download repo link on the live site, https://developers.google.com/codelabs/pwa-training/pwa03--going-offline#1, as of 10/15/21 . The app still fails on the same defaultTabBinding error. I was able to manually edit the js/app/editor.js as proposed by the fix above, and move past the error

@bryan-gilbert
Copy link

bryan-gilbert commented Nov 21, 2021

Can someone please accept the pull request or create a new one... or update the readme to say the project is broken? Thanks. I got stuck at step 0 because of this issue and I look forward to resuming the tutorial.

I found other errors with this sample app that I did not have time to resolve. Instead I found a MDN doc sample application here https://github.com/mdn/pwa-examples

@MayuraRam
Copy link

Please update the codelabs for this issue..

@philipjoseparampettu
Copy link

Issue is still existing in both the source code which is availble for download and in git hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants