Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined value of screens #2

Open
mukeshgurpude opened this issue May 9, 2021 · 0 comments
Open

Undefined value of screens #2

mukeshgurpude opened this issue May 9, 2021 · 0 comments

Comments

@mukeshgurpude
Copy link

In actions.js below code is used to get the array with multiple screens..

// Line 151 of actions.js, Branch: pwa06--service-worker-includes
const { screens } = await window.getScreens()

It throws below error when preview is triggered, as window.getScreens returns an array not an object..

image

Quick, fix to this error might be to just assign the array directly to screens variable, by removing curly braces

const screens  = await window.getScreens();

Alternatively, maybe global variable screen can be used to show the preview at correct position
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mukeshgurpude