-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apart from light
and dark
, add a system
option
#46
Comments
If you never touch the toggle, it uses what the system says. |
@tomayac yes, I'm aware of that, but if I (as a random user) once accidentally touch the toggle, I can never go back (I have no idea how to clear local storage). Is that supposed to work like that? I think there could be a better solution. |
If the toggle doesn't have the Let's assume the system preference is light mode.
|
(It's up to the site owner to choose if they set the |
this is just bad UX. interacting with UI that cannot be undone, and practically speaking, is not recoverable for users, is bad design. a pretty fundamental key UI principle is that actions be easy reversible which this violates. it's not like Google doesn't know how to write this behavior. some of its properties have a tristate theme selector. |
I changed my mind and now do think we should have at least an option to have a three-way toggle. Is anyone on this thread happy to work on a PR that adds such a feature? |
Functionality-wise, the "system" option would just need to delete the localStorage entry. The actual work would more need to focus on how to expose this UI wise. Some of the properties need rethinking, and the HTML structure, too. The appearance |
for me, the most time consuming part is the graphics, not the underlying logic. do we have an icon ready-to-go here ? |
I have seen sites use a slash icon like this. |
Is there any way (currently) or are there any plans on adding a system theme option that would just reflect the system and not override it? Or do I have to somehow make a custom one that clears the localStorage?
The text was updated successfully, but these errors were encountered: