Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated styles when using additionalStylesheets option #88

Open
rschristian opened this issue Nov 10, 2021 · 2 comments
Open

Duplicated styles when using additionalStylesheets option #88

rschristian opened this issue Nov 10, 2021 · 2 comments

Comments

@rschristian
Copy link
Contributor

rschristian commented Nov 10, 2021

The test added in #87 acts as a reproduction.

The basic gist of the issue is that the pattern used for additionalStylesheets can match the main CSS file, which causes its styles to be duplicated.

If we use a pattern like *.css, the sheet's contents will be added once from additionalStylesheets() and again from embedLinkedStylesheets().

It seems that in the past the use of cssnano deduped these styles and hid the issue, though the current solution doesn't offer that same benefit.

Not sure whether this is a regression or just chance behavior that was relied upon.

@developit
Copy link
Collaborator

I've run into this as well in the past week.

@developit
Copy link
Collaborator

It looks like we'll need to bring back the option of running stylesheets through cssnano.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants