Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop building our libraries separately #133

Closed
emaxx-google opened this issue Jun 22, 2020 · 1 comment
Closed

Stop building our libraries separately #133

emaxx-google opened this issue Jun 22, 2020 · 1 comment

Comments

@emaxx-google
Copy link
Collaborator

Currently, the build process is organized in a way that each sub-library (like //common/cpp) is built separately and then has its .lib+.h files installed into a common place (in the NaCl environment). The .lib files are then used when linking the resulting executable.

The original motivation behind this approach is pretty much described in issue #132; additionally, it allows to avoid recompiling a library multiple times for different executables and to test it without compiling the rest of the code. However, similar to that issue, the benefits of that approach don't outweigh the complexity and the fragility caused by it.

Therefore the suggestion is to get rid of that model and separate .lib files, and instead directly compile every library's source file as part of the resulting target.

@emaxx-google
Copy link
Collaborator Author

I'm not sure anymore it'd be a good idea. This would be non-conventional (given that the code is actually consisting of several self-contained blocks that come from different upstreams and are compiled with different flags). Implementation-wise it'd also be weird.

@emaxx-google emaxx-google closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant