Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of relying on pre-set env variables in build scripts #123

Open
emaxx-google opened this issue Jun 9, 2020 · 0 comments
Open

Get rid of relying on pre-set env variables in build scripts #123

emaxx-google opened this issue Jun 9, 2020 · 0 comments
Assignees

Comments

@emaxx-google
Copy link
Collaborator

Currently, one has to run "source env/activate" before being able to compile the code, otherwise the Make will fail with unclear errors (like complaining about the NACL_SDK_ROOT directory).

We should probably get rid of that and change our Makefile's to do this automatically, since the current situation is confusing for developers. Historically, this was done in accordance to the standard Native Client development practice, allowing to reuse an SDK between multiple projects or switch between different SDK versions, but in the light of NaCl deprecation this isn't useful anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant