Re-enable INCOMING_MODULE_JS_API in WebAssembly builds
#1124
Comments
emaxx-google
added a commit
that referenced
this issue
Jan 24, 2024
This flag is broken in recent Emscripten versions: see emscripten-core/emscripten#21167 and emscripten-core/emscripten#20457. Stop using it until it gets fixed in Emscripten (tracking issue #1124).
emaxx-google
added a commit
that referenced
this issue
Feb 1, 2024
This flag is broken in recent Emscripten versions: see emscripten-core/emscripten#21167 and emscripten-core/emscripten#20457. Stop using it until it gets fixed in Emscripten (tracking issue #1124).
emaxx-google
added a commit
that referenced
this issue
Feb 1, 2024
This flag is broken in recent Emscripten versions: see emscripten-core/emscripten#21167 and emscripten-core/emscripten#20457. Stop using it until it gets fixed in Emscripten (tracking issue #1124). We used this flag as a pure optimization, to it's not critical to have it enabled now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Emscripten's
INCOMING_MODULE_JS_APIparameter has been broken: see emscripten-core/emscripten#21167. It became even more broken in recent versions, causing runtime breakages in our code: emscripten-core/emscripten#20457. To unblock our upreving to the recent Emscripten versions, we should temporarily stop usingINCOMING_MODULE_JS_API.However once the quoted Emscripten issues get resolved, we should re-enable
INCOMING_MODULE_JS_APIback as it brings noticeable output size reduction.The text was updated successfully, but these errors were encountered: