Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sendToAnalytics() example #81

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Update sendToAnalytics() example #81

merged 1 commit into from
Oct 22, 2020

Conversation

philipwalton
Copy link
Member

Fixes #77

This PR simplifies the sendToAnalytics() function to just send the metric name and value as a JSON object, rather than stringifying the entire metric object (which includes the various performance entries). The issue is, in some cases performance entries cannot be JSON stringified.

@philipwalton philipwalton merged commit 39a0937 into master Oct 22, 2020
@philipwalton philipwalton deleted the update-readme branch October 22, 2020 04:09
thisgeek added a commit to thisgeek/create-react-app that referenced this pull request Feb 3, 2021
Update sendToAnalytics example to match with GoogleChrome/web-vitals#81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Following the instructions on how to send results to an analytics endpoint gives an error
1 participant