solved the scaling issue when going up/down #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theDRB123 is it possible for you to merge master into your branch, master has the modified Perlin call to fix the color change issue. |
|
refer to a2e1e9c to see the changes made |
theDRB123
force-pushed
the
theDRB's-branch
branch
from
647dc7b
to
af3b197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem appeared to be complex , but was solved by just changing how the combination of PosX and x changes , depending on the heightfromground ,
changes :
PosX doesn't need to scale with changing height so it is fixed ,
the x is replaced by x-width/2 , and y is replaced with y - height/2 to bring the origin of scaling from upper left corner to the center