Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player stops streaming randomly and goes blank #47

Open
danstiner opened this issue Dec 14, 2020 · 4 comments
Open

Player stops streaming randomly and goes blank #47

danstiner opened this issue Dec 14, 2020 · 4 comments

Comments

@danstiner
Copy link
Collaborator

danstiner commented Dec 14, 2020

I've noticed while starting load testing that the player inevitably stops streaming after some time. It's not completely random, it seems to be related to data not flowing fast enough, the stream stops and the video goes blank. Sometimes it resumes correctly after a second but sometimes it never comes back.

I think that because this seems to happen more when more concurrent streams are running, or especially when the are CPU spikes from starting several streams at the same time.

Also because of these logs I see in the web console when a stream stops:

Janus slow link: undefined
Remote track muted: Event {isTrusted: true, type: "mute", target: MediaStreamTrack, currentTarget: MediaStreamTrack, eventPhase: 2, …}
Removing remote track
Janus remote stream

(Opening here because the player repository does not allow issues)

@danstiner
Copy link
Collaborator Author

I think the next step is better logging, both internally in the player codebase and wiring up to the video element event handlers to understand what's going on.

@haydenmc
Copy link
Member

I suspect this is related to #33

My working theory being that HangupMedia gets called (but not respected) and we just keep shipping packets, causing some confusion.

@danstiner
Copy link
Collaborator Author

danstiner commented Dec 14, 2020

Thanks for looking so quick, that sounds promising.

I'd argue this is a ship blocker. Sometimes things work fine but often my streams cut out after just a couple minutes due to this and the only recovery right now is to refresh the page. That's a very bad user experience.

@haydenmc
Copy link
Member

Agree yeah, I have the HangupMedia bug marked ship blocking (hopefully they're dupes)

haydenmc added a commit that referenced this issue Dec 26, 2020
We log whenever a session calls HangUpMedia, which we haven't implemented yet.

This should help us nail down the source of #47 and #33

Co-authored-by: Hayden McAfee <hayden@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants