Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Result with std::expected #123

Open
danstiner opened this issue Apr 18, 2021 · 0 comments
Open

Replace Result with std::expected #123

danstiner opened this issue Apr 18, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@danstiner
Copy link
Collaborator

danstiner commented Apr 18, 2021

The Result type has served us well but as Hayden pointed out it would be nice to have an error code instead of just a message string.

Rather than extend Result I'd suggest moving to std::expected. It didn't quite make the C++20 standard but the feature is basically ready and there is a nice and popular compat library we can use until the next standard comes out: https://github.com/TartanLlama/expected

@danstiner danstiner added enhancement New feature or request good first issue Good for newcomers labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant