Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor edits to wiki #38

Closed
CouldBeThis opened this issue Nov 26, 2021 · 3 comments
Closed

minor edits to wiki #38

CouldBeThis opened this issue Nov 26, 2021 · 3 comments

Comments

@CouldBeThis
Copy link
Contributor

Hi, While I was reading your wiki I made some minor edits basically for legibility. But it seems there is actually no way to make a PR for a wiki. So if you want, here is a zip of the file + .git with commit history. Sorry not sure if there is a better way?

HugoPhotoSwipe.wiki.zip

Summary of changes:

  • $ from the beginning of code blocks where they were there by mistake
  • changed lists of files to be vertical instead of horizontal (easier to read) or used tree to display complete structure.
    • I assume in the section about copying files from PhotoSwipe repo you intended for the image files to be included along with CSS and JS so that's what is written
  • made one tiny content change in "Adding our first album" to clarify something that tripped me up.

(I did not make any change to reflect #37 because I don't know if my solution is very good.)

If updating this way is too much of a PITA then just close/ignore, you won't hurt my feelings. Just that I'd already done it the work.

@GjjvdBurg
Copy link
Owner

Thanks @CouldBeThis! This is very much appreciated! 👍

It'll take a few days before I can make time to look into this and the other issue in more detail, but I appreciate your help!

@CouldBeThis
Copy link
Contributor Author

CouldBeThis commented Nov 26, 2021

I saw the wiki is actually inside this repo in /docs. Not sure if they are are actually the same file or one creates the other or...? At any rate will give it a shot this way.

I just copied and pasted the end result. All my careful change tracking is lost. :( If you need that you still have to look in the zip. It is very straightforward however so doubtful.

@GjjvdBurg
Copy link
Owner

Thanks @CouldBeThis! I think this can be closed now because #39 is merged, but if I'm wrong please reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants