Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DockStarter work with CoreOS (immutable filesystem, no traditional package manager) #1731

Merged
merged 18 commits into from Feb 23, 2024

Conversation

dylanmtaylor
Copy link
Contributor

@dylanmtaylor dylanmtaylor commented Feb 20, 2024

Pull request

Purpose
Closes #1730.

Tested on ucore-hci from the Universal Blue project. Manual workaround needed for docker compose plugin:

DOCKER_CONFIG=${DOCKER_CONFIG:-$HOME/.docker}
mkdir -p $DOCKER_CONFIG/cli-plugins
curl -SL https://github.com/docker/compose/releases/download/v2.24.5/docker-compose-linux-x86_64 -o $DOCKER_CONFIG/cli-plugins/docker-compose
chmod +x $DOCKER_CONFIG/cli-plugins/docker-compose

I also set SELinux to permissive. After that, it worked perfectly and all my containers spun up. :-)
image

Approach
How does this change address the problem?

  • Uses $HOME/bin instead of /usr for the filesystem
  • Doesn't fail hard if it detects no supported package manager, instead checking if the commands we need are there.

Open Questions and Pre-Merge TODOs
Check all boxes as they are completed

  • Use github checklists. When solved, check the box and explain the answer.

Learning
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem

Requirements
Check all boxes as they are completed

@github-actions github-actions bot added the core Automatic label label Feb 20, 2024
@dylanmtaylor dylanmtaylor changed the title Attempt to make DockStarter work with an immutable filesystem Attempt to make DockStarter work with CoreOS (immutable filesystem, no traditional package manager) Feb 20, 2024
@dylanmtaylor dylanmtaylor changed the title Attempt to make DockStarter work with CoreOS (immutable filesystem, no traditional package manager) Make DockStarter work with CoreOS (immutable filesystem, no traditional package manager) Feb 20, 2024
@dylanmtaylor dylanmtaylor marked this pull request as ready for review February 20, 2024 21:05
@dylanmtaylor dylanmtaylor requested a review from a team as a code owner February 20, 2024 21:05
.scripts/package_manager_run.sh Outdated Show resolved Hide resolved
.scripts/package_manager_run.sh Outdated Show resolved Hide resolved
.scripts/package_manager_run.sh Outdated Show resolved Hide resolved
.scripts/package_manager_run.sh Show resolved Hide resolved
.scripts/symlink_ds.sh Outdated Show resolved Hide resolved
.scripts/package_manager_run.sh Show resolved Hide resolved
.scripts/package_manager_run.sh Outdated Show resolved Hide resolved
.scripts/package_manager_run.sh Outdated Show resolved Hide resolved
.scripts/symlink_ds.sh Outdated Show resolved Hide resolved
.scripts/symlink_ds.sh Outdated Show resolved Hide resolved
.scripts/symlink_ds.sh Outdated Show resolved Hide resolved
.scripts/symlink_ds.sh Outdated Show resolved Hide resolved
@nemchik nemchik changed the base branch from master to os-support February 23, 2024 00:42
@nemchik
Copy link
Member

nemchik commented Feb 23, 2024

Changing branch and merging so I can stage in some additional adjustments.

@nemchik nemchik merged commit fb16a28 into GhostWriters:os-support Feb 23, 2024
12 checks passed
@nemchik nemchik mentioned this pull request Feb 23, 2024
2 tasks
@dylanmtaylor dylanmtaylor deleted the patch-1 branch February 23, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Automatic label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Ability to install in CoreOS
2 participants