Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyload depreciation notice #1475

Open
xybydy opened this issue May 13, 2022 · 13 comments
Open

pyload depreciation notice #1475

xybydy opened this issue May 13, 2022 · 13 comments
Labels
help wanted Extra attention is needed under-consideration Stale Exempt

Comments

@xybydy
Copy link

xybydy commented May 13, 2022

The current image is deprecated and on https://hub.docker.com/r/linuxserver/pyload suggest to migrate to https://github.com/linuxserver/docker-pyload-ng.

It is not a bug but just for you guys to know

@nemchik
Copy link
Member

nemchik commented May 13, 2022

Indeed it is. Thanks for the tip. I think there's been a few deprecations I need to go through. I'll try to find some time to do it soon.

We will need to try running the deprecated container to create a config and then upgrading to the ng container to see if the config still works. If it does then the best action is probably to replace the image in the existing pyload files in the DS repo. If the config does not work (and requires a new config for the ng version) then it will probably mean we will need to deprecate pyload in DS and make new templates with the name pyloadng (ds does not support dashes in container names).

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@nemchik nemchik added help wanted Extra attention is needed under-consideration Stale Exempt and removed no-issue-activity labels Aug 12, 2022
@angrycuban13
Copy link
Contributor

@nemchik do you want to do the same thing we did for the other recently deprecated application? Create a whole new application and set this one to deprecated?

@nemchik
Copy link
Member

nemchik commented Aug 16, 2022

If the app supports direct upgrading we can just change the image and keep everything else the same. If the app advises against direct upgrading, or we can't confirm it works, then deprecating and creating new is the way to go.

@angrycuban13
Copy link
Contributor

angrycuban13 commented Aug 16, 2022

Well this is an LSIO image soooo thats all you to tell us 🤣

@nemchik
Copy link
Member

nemchik commented Aug 16, 2022

There's no clear indication in the lsio docs, or in the pyload docs (upstream), so we'll have to test it.

@apperrault
Copy link

I am not sure if either of you have Pyload loaded, but I have been using it for a while so I can test if you need someone to test

@angrycuban13
Copy link
Contributor

I do not have it installed nor would I know how to test. I would say that the easiest way for you to test would be to modify your docker-compose.yml and change the pyload image with the new one and run ds -c up pyload and let us know of any issues. If there are no issues we can make the change

@apperrault
Copy link

apperrault commented Aug 17, 2022 via email

@angrycuban13
Copy link
Contributor

You can do either. The "correct" way would be to create an override file and define the image there and run ds -c up

@apperrault
Copy link

apperrault commented Aug 18, 2022 via email

@apperrault
Copy link

apperrault commented Aug 18, 2022 via email

@angrycuban13
Copy link
Contributor

Ah bummer, sounds good thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed under-consideration Stale Exempt
Projects
None yet
Development

No branches or pull requests

4 participants