New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unofficial skin sources and add skin event for extensions #4507
Conversation
api/src/main/java/org/geysermc/geyser/api/event/lifecycle/SkinApplyEvent.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/geysermc/geyser/api/skin/SkinGeometry.java
Outdated
Show resolved
Hide resolved
Co-authored-by: chris <github@onechris.mozmail.com>
I'm not a big fan on doing a map lookup for |
We do pass the player UUID but likely some extensions will only want to modify java players and this is the only reliable way of checking, as other methods like checking version of the UUID only are reliable with floodgate, other auth types this falls apart on. |
api/src/main/java/org/geysermc/geyser/api/event/lifecycle/SkinApplyEvent.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/configuration/GeyserConfiguration.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/configuration/GeyserJacksonConfiguration.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/geysermc/geyser/api/event/bedrock/SessionSkinApplyEvent.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that a few annotations/no null checks are missing, those should probably be added :)
All unofficial cape and ears sources have been removed.
Ears/capes are now part of an extension GeyserMC/ThirdPartyCosmetics
New event
SessionSkinApplyEvent
for customising the skin, cape and geometry that's loaded for a player.Needs documentation adding to the wiki and likely some testing to make sure I didn't break any skin stuff.