Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: peer dependency error with React 16 / React 17 #2234

Open
MPeloquin opened this issue Jan 9, 2024 · 1 comment
Open

bug: peer dependency error with React 16 / React 17 #2234

MPeloquin opened this issue Jan 9, 2024 · 1 comment
Labels
bug Something isn't working status:confirmed Described issue has been reproduced by the repo maintainer

Comments

@MPeloquin
Copy link

Describe the bug

The peer dependencies have "react": "^18.0.0 || ^17.0.0 || ^16.8.0", but if you install it with react 16.8, there will be peer-dependencies issues because of react-markdown 9.0.0 which has "react": ">=18" in its peer-dependencies.

It seems to work at runtime for us locally, but was breaking our tests & build

It is ok to drop support for old React versions, but it should be clear in the peer-dependencies so we don't try to update yet

To Reproduce

Steps to reproduce the behavior:

  1. Have project with React 16
  2. Install latest stream-chat-react
  3. run install
  4. See peer-dependencies issue:
└─┬ stream-chat-react 11.2.1
  └─┬ react-markdown 9.0.1
    └── ✕ unmet peer react@>=18: found 16.14.0

Expected behavior

Peer-dependencies of stream-chat-react should reflect real version needs

Package version

  • stream-chat-react: 11.2.1

Desktop (please complete the following information):

  • OS: macos
  • Browser chrome
  • Version latest
@MPeloquin MPeloquin added bug Something isn't working status: unconfirmed labels Jan 9, 2024
@MartinCupela
Copy link
Contributor

@MPeloquin thank you for raising the issue. We will try that the react-markdown lib incorporates wider range for peer deps. We need to keep our libraries up-to-date, but at the same time need to support those that have not migrated to v18 yet. Thank you for understanding.

@MartinCupela MartinCupela added status:confirmed Described issue has been reproduced by the repo maintainer and removed status: unconfirmed labels Jan 10, 2024
@oliverlaz oliverlaz changed the title bug: No longer works with React 16 / React 17 bug: peer dependency warning with React 16 / React 17 Jan 10, 2024
@oliverlaz oliverlaz changed the title bug: peer dependency warning with React 16 / React 17 bug: peer dependency error with React 16 / React 17 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:confirmed Described issue has been reproduced by the repo maintainer
Projects
None yet
Development

No branches or pull requests

2 participants