Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7 8 + Major Updates #1344

Open
tablatronix opened this issue Aug 28, 2021 · 3 comments
Open

PHP 7 8 + Major Updates #1344

tablatronix opened this issue Aug 28, 2021 · 3 comments
Labels
DEV Documentation PHP_D PHP version deprecation or fixup

Comments

@tablatronix
Copy link
Member

Ill make a PR but tracking for php deprecation warnings or major ver breaking changes to be fixed.

@tablatronix tablatronix added Documentation DEV PHP_D PHP version deprecation or fixup labels Aug 28, 2021
@tablatronix
Copy link
Member Author

#1246
#1223
#1269
#1343

@BurninLeo
Copy link

There is this line in changedata.php (twice)

if (isset($i18n['TRANSLITERATION']) && is_array($translit=$i18n['TRANSLITERATION']) && count($translit>0)) {

The count($translit>0) is probably meant to be (count($translit)>0) or better !empty($translit) - PHP 8.1 stopped processing there for me.

@BurninLeo
Copy link

This function in admin/inc/basic.php breaks edits in PHP 8.1, because there is no more get_magic_quotes_gpc()

function safe_slash_html($text) {
	if (get_magic_quotes_gpc()==0) {
		$text = addslashes(htmlspecialchars($text, ENT_QUOTES, 'UTF-8'));
	} else {
		$text = htmlspecialchars($text, ENT_QUOTES, 'UTF-8');
	}
	return xmlFilterChars($text);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV Documentation PHP_D PHP version deprecation or fixup
Projects
None yet
Development

No branches or pull requests

2 participants