Function suggest_site_path has problem with nginx

[mittus]

Hello!! It's for GS 3.3.16

I use regexp on Nginx, my siteurl defined with $_SERVER['SERVER_NAME'] as regexp:

Can you change it to $_SERVER['HTTP_HOST'] ?
And can you remove error if I use only slash in the siteurl settings.php

[tablatronix]

You can manually set your siteurl, hav you tried that?

[tablatronix]

Maybe I am thinking siteurl.. let me check, I dont think $_SERVER['HTTP_HOST'] is secure

[mittus]

I use "/" in hosts becouse work with git. Maybe can add parametr "allowed hosts" for GS and validate it for HTTP_HOST?

$allowed_hosts = array('foo.example.com', 'bar.example.com');
if (!isset($_SERVER['HTTP_HOST']) || !in_array($_SERVER['HTTP_HOST'], $allowed_hosts)) {
    header($_SERVER['SERVER_PROTOCOL'].' 400 Bad Request');
    exit;
}

[mittus]

I can create that functional and make function for conversion $SITEURL to fullpath if it has only slash in settings.php

Do it?

[tablatronix]

Curious what exactly are you doing, I Just like to know use cases and what people are coming up with.

[tablatronix]

Maybe we can add a global and if it is set return that instead and you can define this in gsconfig ?

GSSERVERNAME = $_SERVER['SERVER_NAME'];

[mittus]

Done.

With $SITEURL I think, that it need be changed to the $fullpacth anywhere, where needed absolute patch.

[tablatronix]

This is probably a little different in 3.4 as some work has been done for relative paths etc.

[mittus]

What you think about this hotfixes for 3.3.16? I do not plan to update released sites to 3.4 and this problem remains for them

[tablatronix]

I will have to implement it as an optional toggle or something, not just that. And I need a better description of what you are doing, so we can document it