Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROM Properties page displays incorrectly with StartAllBack installed #399

Open
kristibektashi opened this issue Dec 3, 2023 · 3 comments
Open

ROM Properties page displays incorrectly with StartAllBack installed #399

kristibektashi opened this issue Dec 3, 2023 · 3 comments

Comments

@kristibektashi
Copy link

When you install StartAllBack and enable dark mode in the settings, the File Explorer properties dialogs also show in dark mode. However this causes issues with the Rom Properties page where some parts are still bright and the text is unreadable.
imageimage
@ionuttbara
Copy link

+1

GerbilSoft added a commit that referenced this issue Jan 14, 2024
@GerbilSoft
[win32] Forward WM_CTLCOLOR* messages to fix Dark mode on Win11 with …
7177aed 
…StartAllBack installed.

See #399: ROM Properties page displays incorrectly with StartAllBack installed
Reported by @kristibektashi.

Updated RP_ShellPropSheetExt and RP_XAttrView with this change.

FIXME:
- "Warning" colors aren't working. The text shows up as black.
- The "Options" button has black text in Dark mode.
- In "Light" mode, the dialog background color looks "off". Maybe only do
  the forwarding if "Dark" mode is enabled?
  - Need to force a refresh if the color scheme changes?
@GerbilSoft
Copy link
Owner

GerbilSoft commented Jan 14, 2024 •
edited

Please test the DLLs in this build (once it finishes): https://ci.appveyor.com/project/GerbilSoft/rom-properties/builds/48949174/job/yuae38ythykwmx91

The main fix was forwarding WM_CTLCOLOR* messages to the parent dialog. StartAllBack intercepts those messages and remaps them for use with its enhanced dark mode functionality.

Some stuff still isn't working right now:

  • "Warning" messages don't appear in red. A "warning" message shows up in certain cases, e.g. if you open a Dreamcast VMI file and the corresponding VMS file is missing (or vice-versa).
  • The "Options" button still has black text.

I'll note that the tab background color still isn't quite right. (It's too dark compared to other tabs.) I'll need to do some more investigation into figuring that out.

@ionuttbara
Copy link

ionuttbara commented Jan 15, 2024 •
edited

this is good. in normal windows 11. i can say this is fixed. 😊 the options text color is not changed.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GerbilSoft @kristibektashi @ionuttbara