Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort tcevent if rmax missing #66

Open
benjimin opened this issue Mar 21, 2019 · 1 comment
Open

Abort tcevent if rmax missing #66

benjimin opened this issue Mar 21, 2019 · 1 comment
Labels
Bug Configuration Must have

Comments

@benjimin
Copy link
Collaborator

benjimin commented Mar 21, 2019 •
edited

Currently, if config for tcevent.py specifies a track source that lacks vmaxrmax then TCRM generates zeros for it and still continues processing (eventually resulting in empty plots). For example, this may occur if attempting to obtain a track from IBTRACS (which is encouraged for other TCRM workflows) rather than recent-decade JTWC.

If the user's config explicitly describes an input of inappropriate type for the requested process, should abort with error rather than produce invalid output.
@benjimin benjimin mentioned this issue Mar 21, 2019
Open
@wcarthur
Copy link
Member

Is it vmax or rmax? vmax isn't a required field in either tcrm.py or tcevent.py. If it is rmax, then yes - should abort.

@benjimin benjimin changed the title Abort tcevent if vmax missing Abort tcevent if rmax missing Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Configuration Must have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wcarthur @benjimin