Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort if cannot find config #65

Open
benjimin opened this issue Mar 20, 2019 · 0 comments
Open

Abort if cannot find config #65

benjimin opened this issue Mar 20, 2019 · 0 comments

Comments

@benjimin
Copy link
Collaborator

If TCRM cannot find the config file specified (via shell cmdline args) by the user, as is prone to occur due to TCRM interpreting paths differently than the parent shell, then it continues and executes some processes in accordance with defaults, which is misleading to debug.

Suggested actions:

  • TCRM should abort with error, if explicit specifications by user cannot be followed (e.g. if standard library ConfigParser.read returns empty).
  • Should use importlib.resources (preferred) or pkg_resources rather than modifying working directory, and certainly should not do latter before finished processing command line arguments. (Dovetails with using standard install methods, perhaps in develop mode, instead of customising shell environment.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants