Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Use coherence to identify best reference pixel #10

Open
mcgarth opened this issue Jun 1, 2015 · 6 comments
Open

Enhancement: Use coherence to identify best reference pixel #10

mcgarth opened this issue Jun 1, 2015 · 6 comments

Comments

@mcgarth
Copy link
Contributor

mcgarth commented Jun 1, 2015

Use amplitude or coherence image to detect a pixel/region that is always bright or always coherent in the interferograms. This indicates low phase noise and relative stability

@ghost ghost added the enhancement label Jun 16, 2015
@basaks basaks self-assigned this Dec 24, 2015
@basaks
Copy link
Contributor

basaks commented Dec 24, 2015

reference pixel calculation has been there for a while and recently updated to match that of Matlab's reference pixel calculation.
Discuss with MG before closing.

@basaks
Copy link
Contributor

basaks commented Jan 20, 2016

Specifically look at the changes in these functions:

refpixel._step
refpixel.ref_pixel
tests/test_refpixel.test_refnxy_step_1

@basaks
Copy link
Contributor

basaks commented Jan 21, 2016

Matt and I agreed to close this.

@basaks basaks closed this as completed Jan 21, 2016
@mcgarth
Copy link
Contributor Author

mcgarth commented Jan 21, 2016

Reopening: The original enhancement has not been implemented yet, since it will use coherence and/or amplitude images that are not currently read in to PyRate.

@mcgarth mcgarth reopened this Jan 21, 2016
@sheecegardezi
Copy link
Contributor

New functionality has to be added at:

refy, refx = mpiops.run_once(refpixel.find_min_mean, mean_sds, grid)

@mcgarth mcgarth changed the title Enhancement: reference pixel calculation Enhancement: Use coherence to identify best reference pixel Apr 30, 2021
@mcgarth
Copy link
Contributor Author

mcgarth commented Apr 30, 2021

Coherence data is now read in prepifg and would be available for this enhancement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants