Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specified drifts on universal kriging #111

Open
ghost opened this issue Oct 7, 2018 · 2 comments
Open

Specified drifts on universal kriging #111

ghost opened this issue Oct 7, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 7, 2018

I believe spec_vals.flatten()[j] should be instead of spec_vals.flatten()[i] on this line. Let me know if it is correct or not. If so, same line should be corrected on uk3d class.

https://github.com/bsmurphy/PyKrige/blob/db07202a4ff1cbe9a2211db5976a1511ab34fc21/pykrige/uk.py#L841

@ghost ghost changed the title Specified drifts on 3D rigging Specified drifts on universal knifing Oct 7, 2018
@ghost ghost changed the title Specified drifts on universal knifing Specified drifts on universal kriging Oct 7, 2018
@rth
Copy link
Contributor

rth commented Nov 22, 2018

Thanks for the suggestion, @landsite. I'm not very familiar with that part of the code. Is there a test we could write to validate this?

@MuellerSeb
Copy link
Member

We could run a comparison against the GSTools Universal Kriging routine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants