Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate category, tag, and author pages #32

Closed
wants to merge 9 commits into from

Conversation

dajocarter
Copy link
Contributor

This should close #31

dots = true
NavItem = (
<div className="navbar-item" key={`page-${index}`}>
<Link to={i === 0 ? `/` : `/${index}`}>{index}</Link>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve been thinking a bit about this one. We have a pagination helper in the awesome pagination plugin. The trick is, we also support defining a function to calculate what the paginated paths should be. In that case, there’s no way to calculate the page number links without that function.

I’m thinking maybe we add some logic that allows for that function to be passed to the pagination component, with the same default used in both the paginate() function and the component. It’s an interesting one. Will give it a little more thought...

@chmac chmac closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paginate category, tag & author pages
2 participants