Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to QgsBlockingNetworkRequest #117

Open
nilsnolde opened this issue Jun 14, 2020 · 2 comments
Open

Switch to QgsBlockingNetworkRequest #117

nilsnolde opened this issue Jun 14, 2020 · 2 comments
Assignees
@merydian
Labels
investigate

Comments

@nilsnolde
Copy link
Contributor

nilsnolde commented Jun 14, 2020 •
edited

Ref maptiler/qgis-maptiler-plugin#80 (comment)

Current implementation can and will cause crashes > QGIS 3.4
TheGreatRefrigerator added a commit that referenced this issue Mar 30, 2023
@TheGreatRefrigerator
Merge pull request #179 from GIScience/fix/#117-explicit-geometry-type
9bc8740 
Fix/#117 explicit geometry type
@MichaelsJP MichaelsJP added easy fix Issues that are rather quick to be resolved investigate and removed easy fix Issues that are rather quick to be resolved labels Oct 2, 2023
@merydian
Copy link
Collaborator

merydian commented Oct 5, 2023

qgis/QGIS#53721 could be of concern. Using QgsBlockingNetworkRequest might log sensitive information.

@koebi
Copy link
Collaborator

koebi commented Nov 6, 2023

Maybe we should switch to QgsNetworkAccessManager and see where that gets us ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merydian merydian

Labels
investigate
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

117-switch-to-qgsblockingnetworkrequest GIScience/orstools-qgis-plugin
4 participants
@koebi @MichaelsJP @nilsnolde @merydian