Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review configuration #1771

Open
1 task done
sfendrich opened this issue Apr 3, 2024 · 0 comments
Open
1 task done

Review configuration #1771

sfendrich opened this issue Apr 3, 2024 · 0 comments

Comments

@sfendrich
Copy link
Contributor

sfendrich commented Apr 3, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

The configuration setup is still a mess and needs to be reviewed:

  • The fallback logic across application.yml and ors-config.yml does not work correctly
  • The commented-out config file sample is incomplete (e.g., core is missing)
  • The "enabled"-flags are useless as yaml supports comments
  • The necessity to configure CH under routing in order to enable RPHAST is intransparent, same for core
  • The relationship between isochrones and fastisochrones is unclear
  • Two names for profiles needed (e.g., bike-regular and cycling-regular)
  • Profile names can be configured but must match fixed values, i.e., they are not configurable in practice (e.g., the profile name cycling-regular can be configured but must match this exact string)
  • ...

Proposed solution

Review current state and implement a proper solution.

Additional context

No response

Forum Topic Link

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
ors general
  
To do
Development

No branches or pull requests

2 participants