Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing way in preprocessed test graph #1761

Open
aoles opened this issue Mar 26, 2024 · 2 comments
Open

Missing way in preprocessed test graph #1761

aoles opened this issue Mar 26, 2024 · 2 comments
Assignees
Projects

Comments

@aoles
Copy link
Member

aoles commented Mar 26, 2024

Problem description

ORS API tests run against HD test graph filtered through either ors-preprocessor or osm-transform fail with the following.

[ERROR] Failures: 
[ERROR]   ResultTest.testWheelchairKerbRestriction:2102 1 expectation failed.
JSON path routes[0].summary.distance doesn't match.
Expected: is <74.1F>
  Actual: <105.9F>

[ERROR]   ResultTest.testWheelchairWidthRestriction:2021 1 expectation failed.
JSON path routes[0].summary.distance doesn't match.
Expected: is <158.7F>
  Actual: <158.8F>

Proposed solution

Check which OSM tags are relevant for wheelchair routing, as probably some of them are discarded by the preprocessor.

@takb takb added this to To do in ors general Mar 26, 2024
@aoles aoles changed the title WHeelchair API test fail on preprocessed test graph Wheelchair API tests fail on preprocessed test graph Mar 26, 2024
@aoles aoles added the bug 🐛 label Mar 26, 2024
@aoles aoles self-assigned this Mar 26, 2024
@aoles
Copy link
Member Author

aoles commented Mar 26, 2024

The problem seems to be caused by a footpath=crossing-type way missing from the processed file. As this is not about missing wheelchair-specific tags but an entire way not being present the issue is not limited to the wheelchair profile only but affects any other profiles allowed to use the missing way, such as foot-walking, for example.

original heidelberg.osm.gz
Screenshot 2024-03-26 at 22 49 56

processed heidelberg.ors.pbf
Screenshot 2024-03-26 at 22 51 48

@aoles aoles changed the title Wheelchair API tests fail on preprocessed test graph Missing way(s) in preprocessed test graph Mar 26, 2024
@aoles
Copy link
Member Author

aoles commented Mar 27, 2024

It seems that the way is missing because for some unclear reason its ID is set to a negative value (-3556006) and only ways with positive IDs are being copied over in the preprocessing.

@aoles aoles changed the title Missing way(s) in preprocessed test graph Missing way in preprocessed test graph Mar 27, 2024
@aoles aoles removed the bug 🐛 label Mar 27, 2024
aoles added a commit to GIScience/osm-transform that referenced this issue Apr 5, 2024
The check is obsolete as OSM way IDs are supposed to be positive. However, negative values can occur in locally edited
files such as the Heidelberg test graph, see GIScience/openrouteservice#1761.
aoles added a commit that referenced this issue Apr 5, 2024
The reduced travel time in the API test is because now the whole way rather than just its fragment is tagged with `footpath=crossing`. The crossing is necessary to pick up kerb height. Closes #1761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
ors general
  
To do
Development

No branches or pull requests

1 participant