Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch secret storage from keyring to .Renviron #34

Open
aoles opened this issue Jun 11, 2018 · 1 comment
Open

Switch secret storage from keyring to .Renviron #34

aoles opened this issue Jun 11, 2018 · 1 comment
Assignees
Labels
💡 enhancement New feature or request ⚠️ URGENT
Milestone

Comments

@aoles
Copy link
Member

aoles commented Jun 11, 2018

Abandon the notorious keyring package which is causing trouble under certain architectures and deployment environments such as shinyapps.io.

The idea is to store the key as plain environment variable, preferable in .Renviron. In order to ease-up the set-up procedure and to retain previous functionality introduce an intelligent way of updating .Renviron through a call to ors_api_key(<YOUR_API_KEY>). See ?Startup for R startup details.

To remain CRAN compliant, ask for user permission before updating .Renviron (see e.g. rsam).

@aoles aoles added the 💡 enhancement New feature or request label Jun 11, 2018
@aoles aoles added this to the version 0.2.0 milestone Jun 11, 2018
@aoles aoles self-assigned this Jun 11, 2018
@aoles aoles added this to To do in version 0.3.0 via automation Jun 11, 2018
@aoles aoles modified the milestones: version 0.2.0, version 0.3.0 Jun 11, 2018
@aoles
Copy link
Member Author

aoles commented Aug 10, 2018

Builds are failing on Travis CI because libsodium-dev system package on which keyring now indirectly depends is not available on Ubuntu 14.04.

@aoles aoles modified the milestones: version 0.3.0, version 0.2.0 Nov 8, 2018
@aoles aoles added this to To do in version 0.2.0 via automation Nov 8, 2018
@aoles aoles removed this from To do in version 0.3.0 Nov 8, 2018
@aoles aoles modified the milestones: version 0.2.0, version 0.4 Apr 12, 2019
@aoles aoles added the ⚠️ URGENT label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 enhancement New feature or request ⚠️ URGENT
Projects
No open projects
version 0.2.0
  
To do
Development

No branches or pull requests

1 participant