Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDefaultProperties() bug #20

Open
rizkg opened this issue Mar 19, 2018 · 2 comments
Open

getDefaultProperties() bug #20

rizkg opened this issue Mar 19, 2018 · 2 comments

Comments

@rizkg
Copy link
Contributor

rizkg commented Mar 19, 2018 •
edited

There is a bug in the getDefaultProperties() function

gatb-core/gatb-core/src/gatb/tools/misc/impl/OptionsParser.cpp

Line 402 in e0c9525

IProperties* OptionsParser::getDefaultProperties ()

If we use an "OptionNoParam" to build an option that takes no parameters, it is always returned by getDefaultProperties(), I do not see any way to tell if this option should be default or not.
gatb-admin pushed a commit that referenced this issue Mar 19, 2018
@rizkg
because of issue #20 we cannot use OptionNoParam in SortingCountAlgor…
d123a6e 
…ithm
@rchikhi
Copy link
Member

rchikhi commented Mar 19, 2018

need help with it?

@rizkg
Copy link
Contributor Author

rizkg commented Mar 19, 2018

I worked around it by removing my OptionNoParam in SortingCount, so nothing urgent.
I do not plan to fix this myself right now (digging into option visitors does not seem fun).
So feel free to fix it, but only if you have nothing better to do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rchikhi @rizkg