Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fields in Relationship model #13

Open
buske opened this issue Oct 12, 2021 · 1 comment
Open

Rename fields in Relationship model #13

buske opened this issue Oct 12, 2021 · 1 comment

Comments

@buske
Copy link
Contributor

buske commented Oct 12, 2021

In this issue, @julesjacobsen suggested renaming the fields in Relationship to be:

  • subject: identifier of the subject Individual; equivalent to the Biolink "Subject"
  • relative: identifier of the relative Individual; equivalent to the Biolink "Object"
  • relationship: the relationship the subject has to the relative (e.g., if the subject is the relative's parent, then relationship would be a descendant of isBiologicalParent[Of])
buske added a commit that referenced this issue Oct 12, 2021
Now that the relationship terms are directional, this updates the terms of the Relationship class to make the statement clearer.
@buske
Copy link
Contributor Author

buske commented Oct 12, 2021

Now that the terms in the KIN ontology are directional, updating these property names is helpful for clarifying this direction. I went ahead and committed this change, but realized now that this breaks the FHIR IG, so think we should hold off on this change until discussing at/after Connect.

@buske buske closed this as completed Oct 12, 2021
@buske buske reopened this Oct 12, 2021
buske added a commit that referenced this issue Oct 12, 2021
Revert pre-emptive property name change included in: 2a317a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant