Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃洜 Tooling: Files copied from lib/ to dist/ in hydration should come from shenanigans-manager #308

Open
3 tasks done
JoshuaKGoldberg opened this issue Aug 19, 2022 · 0 comments
Labels
area: tooling Builds, infrastructure, packages, and other repository management package: shenanigans-manager status: accepting prs Go ahead and send a pull request to resolve this issue!

Comments

@JoshuaKGoldberg
Copy link
Member

Tooling Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

// Optimization: copy everything from lib/ into dist/
// (this way the same files don't need to be in shenanigans-manager twice)

This is good and necessary, but the lib/ folder can have a bunch of extra cruft added to it from yarn compile. Re-running yarn hydrate after yarn compile means they all get copied to dist/. Annoying.

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Go ahead and send a pull request to resolve this issue! package: shenanigans-manager area: tooling Builds, infrastructure, packages, and other repository management labels Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Builds, infrastructure, packages, and other repository management package: shenanigans-manager status: accepting prs Go ahead and send a pull request to resolve this issue!
Projects
None yet
Development

No branches or pull requests

1 participant