Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msg_amount() is a duplication of balance() #5338

Open
Braqzen opened this issue Dec 1, 2023 · 1 comment · May be fixed by #5491
Open

msg_amount() is a duplication of balance() #5338

Braqzen opened this issue Dec 1, 2023 · 1 comment · May be fixed by #5491
Labels
code quality lib: std Standard library

Comments

@Braqzen
Copy link
Contributor

Braqzen commented Dec 1, 2023

It just calls the function

sway/sway-lib-std/src/context.sw

Lines 75 to 77 in e70cb77

pub fn msg_amount() -> u64 {
balance()
}

but it has a friendlier name.

We ought to only have 1 implementation.
@Braqzen Braqzen added bikeshedding For bikeshedding trivialities lib: std Standard library code quality labels Dec 1, 2023
@Braqzen Braqzen removed the bikeshedding For bikeshedding trivialities label Dec 19, 2023
@Braqzen
Copy link
Contributor Author

Braqzen commented Dec 19, 2023

Remove balance() in favour of msg_amount()

@Halimao Halimao linked a pull request Jan 17, 2024 that will close this issue
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refacto: remove balance() Halimao/sway
1 participant
@Braqzen